)]}'
{"id":"AICP%2Fpackages_services_OmniJaws~122691","triplet_id":"AICP%2Fpackages_services_OmniJaws~v15.0~I79c1706246cd60df6f6a651147bfa2379e2999e8","project":"AICP/packages_services_OmniJaws","branch":"v15.0","topic":"v-OmniJaws","hashtags":[],"change_id":"I79c1706246cd60df6f6a651147bfa2379e2999e8","subject":"OmniJaws: Fix crash when service is disabled with widget on homescreen","status":"MERGED","created":"2025-09-01 15:27:35.000000000","updated":"2025-09-16 19:46:46.000000000","submitted":"2025-09-16 19:46:46.000000000","submitter":{"_account_id":1375,"name":"Julian Veit","email":"claymore1298@gmail.com","username":"Claymore1297","avatars":[{"url":"https://www.gravatar.com/avatar/60897a3259c97a066a0a9e9eababb509.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60897a3259c97a066a0a9e9eababb509.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60897a3259c97a066a0a9e9eababb509.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60897a3259c97a066a0a9e9eababb509.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"status":"♚"},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"122681","meta_rev_id":"3bd543ee1bf4f96d1a63ac74d8062fd7d19820ca","_number":122691,"virtual_id_number":122691,"owner":{"_account_id":1375,"name":"Julian Veit","email":"claymore1298@gmail.com","username":"Claymore1297","avatars":[{"url":"https://www.gravatar.com/avatar/60897a3259c97a066a0a9e9eababb509.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60897a3259c97a066a0a9e9eababb509.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60897a3259c97a066a0a9e9eababb509.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60897a3259c97a066a0a9e9eababb509.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"status":"♚"},"actions":{},"labels":{"Code-Review":{"all":[{"value":0,"_account_id":1375,"name":"Julian Veit","email":"claymore1298@gmail.com","username":"Claymore1297","avatars":[{"url":"https://www.gravatar.com/avatar/60897a3259c97a066a0a9e9eababb509.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60897a3259c97a066a0a9e9eababb509.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60897a3259c97a066a0a9e9eababb509.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60897a3259c97a066a0a9e9eababb509.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"status":"♚"}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"all":[{"value":0,"_account_id":1375,"name":"Julian Veit","email":"claymore1298@gmail.com","username":"Claymore1297","avatars":[{"url":"https://www.gravatar.com/avatar/60897a3259c97a066a0a9e9eababb509.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60897a3259c97a066a0a9e9eababb509.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60897a3259c97a066a0a9e9eababb509.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60897a3259c97a066a0a9e9eababb509.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"status":"♚"}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{},"pending_reviewers":{},"reviewer_updates":[],"messages":[{"id":"6bdf38b8ecf03eead6b75542909ed45c4a78c888","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":1375,"name":"Julian Veit","email":"claymore1298@gmail.com","username":"Claymore1297","avatars":[{"url":"https://www.gravatar.com/avatar/60897a3259c97a066a0a9e9eababb509.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60897a3259c97a066a0a9e9eababb509.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60897a3259c97a066a0a9e9eababb509.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60897a3259c97a066a0a9e9eababb509.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"status":"♚"},"date":"2025-09-01 15:27:35.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"3bd543ee1bf4f96d1a63ac74d8062fd7d19820ca","tag":"autogenerated:gerrit:merged","author":{"_account_id":1375,"name":"Julian Veit","email":"claymore1298@gmail.com","username":"Claymore1297","avatars":[{"url":"https://www.gravatar.com/avatar/60897a3259c97a066a0a9e9eababb509.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60897a3259c97a066a0a9e9eababb509.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60897a3259c97a066a0a9e9eababb509.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60897a3259c97a066a0a9e9eababb509.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"status":"♚"},"date":"2025-09-16 19:46:46.000000000","message":"Change has been successfully pushed.","accounts_in_message":[],"_revision_number":1}],"current_revision_number":1,"current_revision":"6c8b51f1dd7f0416dd0f5e7f45b136814aa076f4","revisions":{"6c8b51f1dd7f0416dd0f5e7f45b136814aa076f4":{"kind":"REWORK","_number":1,"created":"2025-09-01 15:27:35.000000000","uploader":{"_account_id":1375,"name":"Julian Veit","email":"claymore1298@gmail.com","username":"Claymore1297","avatars":[{"url":"https://www.gravatar.com/avatar/60897a3259c97a066a0a9e9eababb509.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/60897a3259c97a066a0a9e9eababb509.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/60897a3259c97a066a0a9e9eababb509.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/60897a3259c97a066a0a9e9eababb509.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"status":"♚"},"ref":"refs/changes/91/122691/1","fetch":{"anonymous http":{"url":"https://gerrit.aicp-rom.com/AICP/packages_services_OmniJaws","ref":"refs/changes/91/122691/1","commands":{"Branch":"git fetch https://gerrit.aicp-rom.com/AICP/packages_services_OmniJaws refs/changes/91/122691/1 \u0026\u0026 git checkout -b change-122691 FETCH_HEAD","Checkout":"git fetch https://gerrit.aicp-rom.com/AICP/packages_services_OmniJaws refs/changes/91/122691/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.aicp-rom.com/AICP/packages_services_OmniJaws refs/changes/91/122691/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.aicp-rom.com/AICP/packages_services_OmniJaws refs/changes/91/122691/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.aicp-rom.com/AICP/packages_services_OmniJaws refs/changes/91/122691/1","Reset To":"git fetch https://gerrit.aicp-rom.com/AICP/packages_services_OmniJaws refs/changes/91/122691/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"423dd5235508e9cd03424d8d4743e2686856eaa3","subject":"Add nothing weather icon pack","web_links":[{"name":"Github","tooltip":"Open in GitWeb","url":"https://github.com/AICP/packages_services_OmniJaws/commit/423dd5235508e9cd03424d8d4743e2686856eaa3"}]}],"author":{"name":"Jayant-Deshmukh","email":"jayantdeshmuk008@gmail.com","date":"2024-12-09 16:45:41.000000000","tz":330},"committer":{"name":"Julian Veit","email":"claymore1298@gmail.com","date":"2025-09-01 15:26:03.000000000","tz":0},"subject":"OmniJaws: Fix crash when service is disabled with widget on homescreen","message":"OmniJaws: Fix crash when service is disabled with widget on homescreen\n\nFixes the below -\u003e\n\nCrash Scenario 1:\n1. Enable omnijaws service\n2. Enable widget on homescreen\n3. Disable Omnijaws service\n(Observe crash)\n\nCrash Scenario 2:\n1. Keep Omnijaws service disabled\n2. Try adding homescreen omnijaws widget\n(Observer crash)\n\nLogs:\n\n12-09 22:10:24.555 28715 28715 E AndroidRuntime: FATAL EXCEPTION: main\n12-09 22:10:24.555 28715 28715 E AndroidRuntime: Process: org.omnirom.omnijaws, PID: 28715\n12-09 22:10:24.555 28715 28715 E AndroidRuntime: java.lang.NullPointerException: Attempt to invoke virtual method \u0027boolean java.lang.Object.equals(java.lang.Object)\u0027 on a null object reference\n12-09 22:10:24.555 28715 28715 E AndroidRuntime: \tat com.android.internal.util.superior.OmniJawsClient.isOutlineIconPackage(OmniJawsClient.java:451)\n12-09 22:10:24.555 28715 28715 E AndroidRuntime: \tat org.omnirom.omnijaws.widget.WeatherAppWidgetProvider.createRemoteViews(WeatherAppWidgetProvider.java:319)\n12-09 22:10:24.555 28715 28715 E AndroidRuntime: \tat org.omnirom.omnijaws.widget.WeatherAppWidgetProvider.updateWeather(WeatherAppWidgetProvider.java:186)\n12-09 22:10:24.555 28715 28715 E AndroidRuntime: \tat org.omnirom.omnijaws.widget.WeatherAppWidgetProvider.disableAllWidgets(WeatherAppWidgetProvider.java:443)\n12-09 22:10:24.555 28715 28715 E AndroidRuntime: \tat org.omnirom.omnijaws.SettingsFragment.disableService(SettingsFragment.java:341)\n12-09 22:10:24.555 28715 28715 E AndroidRuntime: \tat org.omnirom.omnijaws.SettingsFragment.onCheckedChanged(SettingsFragment.java:275)\n12-09 22:10:24.555 28715 28715 E AndroidRuntime: \tat com.android.settingslib.widget.MainSwitchBar.propagateChecked(MainSwitchBar.java:228)\n12-09 22:10:24.555 28715 28715 E AndroidRuntime: \tat com.android.settingslib.widget.MainSwitchBar.onCheckedChanged(MainSwitchBar.java:120)\n12-09 22:10:24.555 28715 28715 E AndroidRuntime: \tat android.widget.CompoundButton.setChecked(CompoundButton.java:222)\n12-09 22:10:24.555 28715 28715 E AndroidRuntime: \tat android.widget.Switch.setChecked(Switch.java:1260)\n12-09 22:10:24.555 28715 28715 E AndroidRuntime: \tat android.widget.Switch.toggle(Switch.java:1244)\n12-09 22:10:24.555 28715 28715 E AndroidRuntime: \tat android.widget.CompoundButton.performClick(CompoundButton.java:144)\n12-09 22:10:24.555 28715 28715 E AndroidRuntime: \tat com.android.settingslib.widget.MainSwitchBar.performClick(MainSwitchBar.java:125)\n12-09 22:10:24.555 28715 28715 E AndroidRuntime: \tat android.view.View.performClickInternal(View.java:8013)\n12-09 22:10:24.555 28715 28715 E AndroidRuntime: \tat android.view.View.-$$Nest$mperformClickInternal(Unknown Source:0)\n12-09 22:10:24.555 28715 28715 E AndroidRuntime: \tat android.view.View$PerformClick.run(View.java:31237)\n12-09 22:10:24.555 28715 28715 E AndroidRuntime: \tat android.os.Handler.handleCallback(Handler.java:959)\n12-09 22:10:24.555 28715 28715 E AndroidRuntime: \tat android.os.Handler.dispatchMessage(Handler.java:100)\n12-09 22:10:24.555 28715 28715 E AndroidRuntime: \tat android.os.Looper.loopOnce(Looper.java:232)\n12-09 22:10:24.555 28715 28715 E AndroidRuntime: \tat android.os.Looper.loop(Looper.java:317)\n12-09 22:10:24.555 28715 28715 E AndroidRuntime: \tat android.app.ActivityThread.main(ActivityThread.java:8705)\n12-09 22:10:24.555 28715 28715 E AndroidRuntime: \tat java.lang.reflect.Method.invoke(Native Method)\n12-09 22:10:24.555 28715 28715 E AndroidRuntime: \tat com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:580)\n12-09 22:10:24.555 28715 28715 E AndroidRuntime: \tat com.android.internal.os.ZygoteInit.main(ZygoteInit.java:886)\n\nChange-Id: I79c1706246cd60df6f6a651147bfa2379e2999e8\nSigned-off-by: Jayant-Deshmukh \u003cjayantdeshmuk008@gmail.com\u003e\nSigned-off-by: Pranav Vashi \u003cneobuddy89@gmail.com\u003e\n","web_links":[{"name":"Github","tooltip":"Open in GitWeb","url":"https://github.com/AICP/packages_services_OmniJaws/commit/6c8b51f1dd7f0416dd0f5e7f45b136814aa076f4"}],"resolve_conflicts_web_links":[{"name":"Github","tooltip":"Open in GitWeb","url":"https://github.com/AICP/packages_services_OmniJaws/commit/6c8b51f1dd7f0416dd0f5e7f45b136814aa076f4"}]},"parents_data":[{"branch_name":"refs/heads/v15.0","commit_id":"423dd5235508e9cd03424d8d4743e2686856eaa3","is_merged_in_target_branch":true,"change_id":"I1a7ba21588044d98f6ed9d2ffbde8dc47d8ebd72","change_number":122683,"patch_set_number":2,"change_status":"MERGED"}],"branch":"refs/heads/v15.0"}},"requirements":[],"submit_records":[],"submit_requirements":[]}