)]}'
{"id":"AICP%2Fframeworks_base~35215","triplet_id":"AICP%2Fframeworks_base~n7.1~I0c7baece9501e67b80083d448c51b329653c90f6","project":"AICP/frameworks_base","branch":"n7.1","topic":"aosp-commits","hashtags":[],"change_id":"I0c7baece9501e67b80083d448c51b329653c90f6","subject":"Frameworks/base: Fix old code in MediaPlayer","status":"MERGED","created":"2017-03-28 06:30:05.000000000","updated":"2017-04-05 10:06:53.000000000","submitted":"2017-04-05 10:06:53.000000000","submitter":{"_account_id":152,"name":"Michele Bono","email":"bono.michele94@gmail.com","avatars":[{"url":"https://www.gravatar.com/avatar/a7c7df3d8bbe4387ef5f8bd9c706579e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/a7c7df3d8bbe4387ef5f8bd9c706579e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/a7c7df3d8bbe4387ef5f8bd9c706579e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/a7c7df3d8bbe4387ef5f8bd9c706579e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"inactive":true},"total_comment_count":0,"unresolved_comment_count":0,"has_review_started":true,"submission_id":"35215-1491386813611-49836961","meta_rev_id":"88dc4ad2e3944c80b7687f8ce9b3546ab09dd7f0","_number":35215,"virtual_id_number":35215,"owner":{"_account_id":492,"name":"Alex T.","email":"alex@dragongr.dev","username":"GreekDragon","avatars":[{"url":"https://www.gravatar.com/avatar/f3092de423fb38c4ef8d49e33ddc04f2.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f3092de423fb38c4ef8d49e33ddc04f2.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f3092de423fb38c4ef8d49e33ddc04f2.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f3092de423fb38c4ef8d49e33ddc04f2.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"status":"simp"},"actions":{},"labels":{"Code-Review":{"approved":{"_account_id":152,"name":"Michele Bono","email":"bono.michele94@gmail.com","avatars":[{"url":"https://www.gravatar.com/avatar/a7c7df3d8bbe4387ef5f8bd9c706579e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/a7c7df3d8bbe4387ef5f8bd9c706579e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/a7c7df3d8bbe4387ef5f8bd9c706579e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/a7c7df3d8bbe4387ef5f8bd9c706579e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"inactive":true},"all":[{"value":2,"date":"2017-04-05 10:04:41.000000000","_account_id":152,"name":"Michele Bono","email":"bono.michele94@gmail.com","avatars":[{"url":"https://www.gravatar.com/avatar/a7c7df3d8bbe4387ef5f8bd9c706579e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/a7c7df3d8bbe4387ef5f8bd9c706579e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/a7c7df3d8bbe4387ef5f8bd9c706579e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/a7c7df3d8bbe4387ef5f8bd9c706579e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"inactive":true}],"values":{"-2":"This shall not be merged","-1":"I would prefer this is not merged as is"," 0":"No score","+1":"Looks good to me, but someone else must approve","+2":"Looks good to me, approved"},"description":"","default_value":0},"Verified":{"approved":{"_account_id":152,"name":"Michele Bono","email":"bono.michele94@gmail.com","avatars":[{"url":"https://www.gravatar.com/avatar/a7c7df3d8bbe4387ef5f8bd9c706579e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/a7c7df3d8bbe4387ef5f8bd9c706579e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/a7c7df3d8bbe4387ef5f8bd9c706579e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/a7c7df3d8bbe4387ef5f8bd9c706579e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"inactive":true},"all":[{"value":1,"date":"2017-04-05 10:04:41.000000000","_account_id":152,"name":"Michele Bono","email":"bono.michele94@gmail.com","avatars":[{"url":"https://www.gravatar.com/avatar/a7c7df3d8bbe4387ef5f8bd9c706579e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/a7c7df3d8bbe4387ef5f8bd9c706579e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/a7c7df3d8bbe4387ef5f8bd9c706579e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/a7c7df3d8bbe4387ef5f8bd9c706579e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"inactive":true}],"values":{"-1":"Fails"," 0":"No score","+1":"Verified"},"description":"","default_value":0}},"removable_reviewers":[],"reviewers":{"REVIEWER":[{"_account_id":152,"name":"Michele Bono","email":"bono.michele94@gmail.com","avatars":[{"url":"https://www.gravatar.com/avatar/a7c7df3d8bbe4387ef5f8bd9c706579e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/a7c7df3d8bbe4387ef5f8bd9c706579e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/a7c7df3d8bbe4387ef5f8bd9c706579e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/a7c7df3d8bbe4387ef5f8bd9c706579e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"inactive":true}]},"pending_reviewers":{},"reviewer_updates":[{"updated":"2017-04-05 10:04:41.000000000","updated_by":{"_account_id":152,"name":"Michele Bono","email":"bono.michele94@gmail.com","avatars":[{"url":"https://www.gravatar.com/avatar/a7c7df3d8bbe4387ef5f8bd9c706579e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/a7c7df3d8bbe4387ef5f8bd9c706579e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/a7c7df3d8bbe4387ef5f8bd9c706579e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/a7c7df3d8bbe4387ef5f8bd9c706579e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"inactive":true},"reviewer":{"_account_id":152,"name":"Michele Bono","email":"bono.michele94@gmail.com","avatars":[{"url":"https://www.gravatar.com/avatar/a7c7df3d8bbe4387ef5f8bd9c706579e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/a7c7df3d8bbe4387ef5f8bd9c706579e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/a7c7df3d8bbe4387ef5f8bd9c706579e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/a7c7df3d8bbe4387ef5f8bd9c706579e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"inactive":true},"state":"REVIEWER"}],"messages":[{"id":"6e5e5072a4695a9b22c05404fe460693f4a6df9a","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":492,"name":"Alex T.","email":"alex@dragongr.dev","username":"GreekDragon","avatars":[{"url":"https://www.gravatar.com/avatar/f3092de423fb38c4ef8d49e33ddc04f2.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f3092de423fb38c4ef8d49e33ddc04f2.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f3092de423fb38c4ef8d49e33ddc04f2.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f3092de423fb38c4ef8d49e33ddc04f2.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"status":"simp"},"date":"2017-03-28 06:30:05.000000000","message":"Uploaded patch set 1.","accounts_in_message":[],"_revision_number":1},{"id":"6a296d677c43546555cdfc4d75c9bb9045e9a230","tag":"autogenerated:gerrit:newPatchSet","author":{"_account_id":492,"name":"Alex T.","email":"alex@dragongr.dev","username":"GreekDragon","avatars":[{"url":"https://www.gravatar.com/avatar/f3092de423fb38c4ef8d49e33ddc04f2.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f3092de423fb38c4ef8d49e33ddc04f2.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f3092de423fb38c4ef8d49e33ddc04f2.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f3092de423fb38c4ef8d49e33ddc04f2.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"status":"simp"},"date":"2017-03-28 06:33:09.000000000","message":"Patch Set 2: Patch Set 1 was rebased","accounts_in_message":[],"_revision_number":2},{"id":"fe11b72395407619a43b3d3f2eef6d04828cc864","tag":"autogenerated:gerrit:setTopic","author":{"_account_id":492,"name":"Alex T.","email":"alex@dragongr.dev","username":"GreekDragon","avatars":[{"url":"https://www.gravatar.com/avatar/f3092de423fb38c4ef8d49e33ddc04f2.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f3092de423fb38c4ef8d49e33ddc04f2.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f3092de423fb38c4ef8d49e33ddc04f2.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f3092de423fb38c4ef8d49e33ddc04f2.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"status":"simp"},"date":"2017-03-28 06:33:16.000000000","message":"Topic set to aosp-commits","accounts_in_message":[],"_revision_number":2},{"id":"92de4ca65901718e950356cec41699048d1cb6ce","author":{"_account_id":152,"name":"Michele Bono","email":"bono.michele94@gmail.com","avatars":[{"url":"https://www.gravatar.com/avatar/a7c7df3d8bbe4387ef5f8bd9c706579e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/a7c7df3d8bbe4387ef5f8bd9c706579e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/a7c7df3d8bbe4387ef5f8bd9c706579e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/a7c7df3d8bbe4387ef5f8bd9c706579e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"inactive":true},"date":"2017-04-05 10:04:41.000000000","message":"Patch Set 2: Verified+1 Code-Review+2","accounts_in_message":[],"_revision_number":2},{"id":"88dc4ad2e3944c80b7687f8ce9b3546ab09dd7f0","tag":"autogenerated:gerrit:merged","author":{"_account_id":152,"name":"Michele Bono","email":"bono.michele94@gmail.com","avatars":[{"url":"https://www.gravatar.com/avatar/a7c7df3d8bbe4387ef5f8bd9c706579e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/a7c7df3d8bbe4387ef5f8bd9c706579e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/a7c7df3d8bbe4387ef5f8bd9c706579e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/a7c7df3d8bbe4387ef5f8bd9c706579e.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"inactive":true},"date":"2017-04-05 10:06:53.000000000","message":"Change has been successfully merged by Michele Bono","accounts_in_message":[],"_revision_number":2}],"current_revision_number":2,"current_revision":"b44d1937b104f522a87cabbf0debcecc4d656cca","revisions":{"42cc97b1d303984a84e4f3ff1467e8cde0d512ec":{"kind":"REWORK","_number":1,"created":"2017-03-28 06:30:05.000000000","uploader":{"_account_id":492,"name":"Alex T.","email":"alex@dragongr.dev","username":"GreekDragon","avatars":[{"url":"https://www.gravatar.com/avatar/f3092de423fb38c4ef8d49e33ddc04f2.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f3092de423fb38c4ef8d49e33ddc04f2.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f3092de423fb38c4ef8d49e33ddc04f2.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f3092de423fb38c4ef8d49e33ddc04f2.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"status":"simp"},"ref":"refs/changes/15/35215/1","fetch":{"anonymous http":{"url":"https://gerrit.aicp-rom.com/AICP/frameworks_base","ref":"refs/changes/15/35215/1","commands":{"Branch":"git fetch https://gerrit.aicp-rom.com/AICP/frameworks_base refs/changes/15/35215/1 \u0026\u0026 git checkout -b change-35215 FETCH_HEAD","Checkout":"git fetch https://gerrit.aicp-rom.com/AICP/frameworks_base refs/changes/15/35215/1 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.aicp-rom.com/AICP/frameworks_base refs/changes/15/35215/1 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.aicp-rom.com/AICP/frameworks_base refs/changes/15/35215/1 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.aicp-rom.com/AICP/frameworks_base refs/changes/15/35215/1","Reset To":"git fetch https://gerrit.aicp-rom.com/AICP/frameworks_base refs/changes/15/35215/1 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"0a86c3f0c5b3d8469d5f54787dc7c21c1cb2d5f1","subject":"Fix NPE while performing NetworkStatsService.removeUidsLocked()","web_links":[{"name":"Github","tooltip":"Open in GitWeb","url":"https://github.com/AICP/frameworks_base/commit/0a86c3f0c5b3d8469d5f54787dc7c21c1cb2d5f1"}]}],"author":{"name":"Andreas Gampe","email":"agampe@google.com","date":"2015-03-20 23:45:37.000000000","tz":-420},"committer":{"name":"dragonGR","email":"alextsanisbadlorg@gmail.com","date":"2017-03-28 06:29:47.000000000","tz":0},"subject":"Frameworks/base: Fix old code in MediaPlayer","message":"Frameworks/base: Fix old code in MediaPlayer\n\nInputStream has been replaced with direct fd usage. Remove that\ncode.\n\nRemove extra final variable, rename duped fd variable.\n\nClose the file descriptor when done to avoid a leak.\n\nBug: 19797138\nChange-Id: I0c7baece9501e67b80083d448c51b329653c90f6\n","web_links":[{"name":"Github","tooltip":"Open in GitWeb","url":"https://github.com/AICP/frameworks_base/commit/42cc97b1d303984a84e4f3ff1467e8cde0d512ec"}],"resolve_conflicts_web_links":[{"name":"Github","tooltip":"Open in GitWeb","url":"https://github.com/AICP/frameworks_base/commit/42cc97b1d303984a84e4f3ff1467e8cde0d512ec"}]},"branch":"refs/heads/n7.1"},"b44d1937b104f522a87cabbf0debcecc4d656cca":{"kind":"TRIVIAL_REBASE","_number":2,"created":"2017-03-28 06:33:09.000000000","uploader":{"_account_id":492,"name":"Alex T.","email":"alex@dragongr.dev","username":"GreekDragon","avatars":[{"url":"https://www.gravatar.com/avatar/f3092de423fb38c4ef8d49e33ddc04f2.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d32","height":32},{"url":"https://www.gravatar.com/avatar/f3092de423fb38c4ef8d49e33ddc04f2.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d56","height":56},{"url":"https://www.gravatar.com/avatar/f3092de423fb38c4ef8d49e33ddc04f2.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d100","height":100},{"url":"https://www.gravatar.com/avatar/f3092de423fb38c4ef8d49e33ddc04f2.jpg?d\u003didenticon\u0026r\u003dpg\u0026s\u003d120","height":120}],"status":"simp"},"ref":"refs/changes/15/35215/2","fetch":{"anonymous http":{"url":"https://gerrit.aicp-rom.com/AICP/frameworks_base","ref":"refs/changes/15/35215/2","commands":{"Branch":"git fetch https://gerrit.aicp-rom.com/AICP/frameworks_base refs/changes/15/35215/2 \u0026\u0026 git checkout -b change-35215 FETCH_HEAD","Checkout":"git fetch https://gerrit.aicp-rom.com/AICP/frameworks_base refs/changes/15/35215/2 \u0026\u0026 git checkout FETCH_HEAD","Cherry Pick":"git fetch https://gerrit.aicp-rom.com/AICP/frameworks_base refs/changes/15/35215/2 \u0026\u0026 git cherry-pick FETCH_HEAD","Format Patch":"git fetch https://gerrit.aicp-rom.com/AICP/frameworks_base refs/changes/15/35215/2 \u0026\u0026 git format-patch -1 --stdout FETCH_HEAD","Pull":"git pull https://gerrit.aicp-rom.com/AICP/frameworks_base refs/changes/15/35215/2","Reset To":"git fetch https://gerrit.aicp-rom.com/AICP/frameworks_base refs/changes/15/35215/2 \u0026\u0026 git reset --hard FETCH_HEAD"}}},"commit":{"parents":[{"commit":"1e705faa817269490bb5f409913be300c113d003","subject":"AE moderate language mode [2/2]","web_links":[{"name":"Github","tooltip":"Open in GitWeb","url":"https://github.com/AICP/frameworks_base/commit/1e705faa817269490bb5f409913be300c113d003"}]}],"author":{"name":"Andreas Gampe","email":"agampe@google.com","date":"2015-03-20 23:45:37.000000000","tz":-420},"committer":{"name":"Alex Tsanis","email":"alextsanisbadlorg@gmail.com","date":"2017-03-28 06:33:09.000000000","tz":0},"subject":"Frameworks/base: Fix old code in MediaPlayer","message":"Frameworks/base: Fix old code in MediaPlayer\n\nInputStream has been replaced with direct fd usage. Remove that\ncode.\n\nRemove extra final variable, rename duped fd variable.\n\nClose the file descriptor when done to avoid a leak.\n\nBug: 19797138\nChange-Id: I0c7baece9501e67b80083d448c51b329653c90f6\n","web_links":[{"name":"Github","tooltip":"Open in GitWeb","url":"https://github.com/AICP/frameworks_base/commit/b44d1937b104f522a87cabbf0debcecc4d656cca"}],"resolve_conflicts_web_links":[{"name":"Github","tooltip":"Open in GitWeb","url":"https://github.com/AICP/frameworks_base/commit/b44d1937b104f522a87cabbf0debcecc4d656cca"}]},"branch":"refs/heads/n7.1"}},"requirements":[],"submit_records":[],"submit_requirements":[]}
